From e1eb9b428cdfee0ac5ae072463ca66431077ba27 Mon Sep 17 00:00:00 2001 From: Antoine M Date: Wed, 20 May 2026 10:53:44 +0200 Subject: [PATCH] REFACTOR Simplify target link assignment logic in CTA render files --- plugins/carhop-blocks/build/cta/render.php | 3 +-- plugins/carhop-blocks/src/cta/render.php | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/carhop-blocks/build/cta/render.php b/plugins/carhop-blocks/build/cta/render.php index 6696143..83a1479 100644 --- a/plugins/carhop-blocks/build/cta/render.php +++ b/plugins/carhop-blocks/build/cta/render.php @@ -3,8 +3,7 @@ $align = isset($attributes['align']) ? $attributes['align'] : ''; $link = isset($attributes['link']) ? $attributes['link'] : []; $text = isset($attributes['text']) ? $attributes['text'] : ''; $color = isset($attributes['color']) ? $attributes['color'] : ''; -$target = isset($link) && $link['opensInNewTab'] ? '_blank' : '_self'; - +$target = (isset($link['opensInNewTab']) && $link['opensInNewTab']) ? '_blank' : '_self'; $raw_url = isset($link['url']) ? $link['url'] : ''; $is_inner_page_link = is_string($raw_url) && strpos($raw_url, '#') === 0; diff --git a/plugins/carhop-blocks/src/cta/render.php b/plugins/carhop-blocks/src/cta/render.php index 6696143..83a1479 100644 --- a/plugins/carhop-blocks/src/cta/render.php +++ b/plugins/carhop-blocks/src/cta/render.php @@ -3,8 +3,7 @@ $align = isset($attributes['align']) ? $attributes['align'] : ''; $link = isset($attributes['link']) ? $attributes['link'] : []; $text = isset($attributes['text']) ? $attributes['text'] : ''; $color = isset($attributes['color']) ? $attributes['color'] : ''; -$target = isset($link) && $link['opensInNewTab'] ? '_blank' : '_self'; - +$target = (isset($link['opensInNewTab']) && $link['opensInNewTab']) ? '_blank' : '_self'; $raw_url = isset($link['url']) ? $link['url'] : ''; $is_inner_page_link = is_string($raw_url) && strpos($raw_url, '#') === 0;